[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 03/11] hw/misc: add missing inclu
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes |
|
Date: |
Mon, 8 May 2017 18:56:09 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/hw/misc/unimp.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h
> index 3462d85836..353ee19abf 100644
> --- a/include/hw/misc/unimp.h
> +++ b/include/hw/misc/unimp.h
> @@ -8,6 +8,9 @@
> #ifndef HW_MISC_UNIMP_H
> #define HW_MISC_UNIMP_H
>
> +#include "qemu/osdep.h"
NACK. .h files should not include osdep.h, because the .c file that is
using the .h file should have already done so. This is mentioned in
HACKING.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-trivial] [PATCH 01/11] hw/net: removed obsolete comments, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 05/11] hw/mips: add missing include, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 06/11] hw/arm: removed unnecessary include, Philippe Mathieu-Daudé, 2017/05/08