[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] tests: check-qom-proplist: fix l
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] tests: check-qom-proplist: fix leak |
Date: |
Tue, 11 Jul 2017 07:27:12 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Copying qemu-trivial.
Marc-André Lureau <address@hidden> writes:
> user_creatable_add_opts() returns a reference (the other reference is
> for the root parent/child link).
>
> Leak introduced in commit a1af255f065cc.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/check-qom-proplist.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
> index 8e432e9ab6..a3cd7ab29f 100644
> --- a/tests/check-qom-proplist.c
> +++ b/tests/check-qom-proplist.c
> @@ -428,6 +428,8 @@ static void test_dummy_createcmdl(void)
> g_assert(err == NULL);
> error_free(err);
>
> + object_unref(OBJECT(dobj));
> +
> /*
> * cmdline-parsing via qemu_opts_parse() results in a QemuOpts entry
> * corresponding to the Object's ID to be added to the QemuOptsList
Reviewed-by: Markus Armbruster <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] tests: check-qom-proplist: fix leak,
Markus Armbruster <=