[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 09/13] qga-win32: Fix memory leak of device informa
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 09/13] qga-win32: Fix memory leak of device information set |
Date: |
Wed, 12 Jul 2017 16:38:05 +0300 |
From: Li Ping <address@hidden>
The caller of SetupDiGetClassDevs must delete the returned device information
set when it is no longer needed by calling SetupDiDestroyDeviceInfoList.
Signed-off-by: Li Ping <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
qga/commands-win32.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 439d229225..6f1645747b 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -512,7 +512,7 @@ static GuestPCIAddress *get_pci_info(char *guid, Error
**errp)
} else {
error_setg_win32(errp, GetLastError(),
"failed to get device name");
- goto out;
+ goto free_dev_info;
}
}
@@ -560,6 +560,9 @@ static GuestPCIAddress *get_pci_info(char *guid, Error
**errp)
pci->bus = bus;
break;
}
+
+free_dev_info:
+ SetupDiDestroyDeviceInfoList(dev_info);
out:
g_free(buffer);
g_free(name);
--
2.11.0
- [Qemu-trivial] [PULL 07/13] elf-loader: warn about invalid endianness, (continued)
- [Qemu-trivial] [PULL 07/13] elf-loader: warn about invalid endianness, Michael Tokarev, 2017/07/12
- [Qemu-trivial] [PULL 06/13] configure: Handle having no c++ compiler in FORTIFY_SOURCE check, Michael Tokarev, 2017/07/12
- [Qemu-trivial] [PULL 01/13] target/xtensa: gdbstub: drop dead return statement, Michael Tokarev, 2017/07/12
- [Qemu-trivial] [PULL 02/13] util/qemu-sockets: Drop unused helper socket_address_to_string(), Michael Tokarev, 2017/07/12
- [Qemu-trivial] [PULL 12/13] qobject: Catch another straggler for use of qdict_put_str(), Michael Tokarev, 2017/07/12
- [Qemu-trivial] [PULL 08/13] hw/core: fix missing return value in load_image_targphys_as(), Michael Tokarev, 2017/07/12
- [Qemu-trivial] [PULL 10/13] hxtool: remove dead -q option, Michael Tokarev, 2017/07/12
- [Qemu-trivial] [PULL 05/13] hw/pci: define msi_nonbroken in pci-stub, Michael Tokarev, 2017/07/12
- [Qemu-trivial] [PULL 13/13] qobject: Update coccinelle script to catch Q{INC, DEC}REF, Michael Tokarev, 2017/07/12
- [Qemu-trivial] [PULL 11/13] include/hw/ptimer.h: Add documentation comments, Michael Tokarev, 2017/07/12
- [Qemu-trivial] [PULL 09/13] qga-win32: Fix memory leak of device information set,
Michael Tokarev <=
- [Qemu-trivial] [PULL 04/13] hw/misc: add missing includes, Michael Tokarev, 2017/07/12
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/13] Trivial patches for 2017-07-12, Eric Blake, 2017/07/12