[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 15/29] microblaze: use QEMU_IS_AL
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 15/29] microblaze: use QEMU_IS_ALIGNED macro |
Date: |
Tue, 18 Jul 2017 04:08:11 -0700 |
On Mon, Jul 17, 2017 at 11:09 PM, Philippe Mathieu-Daudé
<address@hidden> wrote:
> Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci
> (also added braces to satisfy checkpatch)
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> target/microblaze/op_helper.c | 3 ++-
> target/microblaze/translate.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/target/microblaze/op_helper.c b/target/microblaze/op_helper.c
> index 1e07e21c1c..41ab52fb7a 100644
> --- a/target/microblaze/op_helper.c
> +++ b/target/microblaze/op_helper.c
> @@ -108,8 +108,9 @@ void helper_debug(CPUMBState *env)
> (env->sregs[SR_MSR] & MSR_IE));
> for (i = 0; i < 32; i++) {
> qemu_log("r%2.2d=%8.8x ", i, env->regs[i]);
> - if ((i + 1) % 4 == 0)
> + if (QEMU_IS_ALIGNED(i + 1, 4)) {
> qemu_log("\n");
> + }
> }
> qemu_log("\n\n");
> }
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index cb65d1e129..ae7b3c71b0 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -1839,9 +1839,10 @@ void mb_cpu_dump_state(CPUState *cs, FILE *f,
> fprintf_function cpu_fprintf,
>
> for (i = 0; i < 32; i++) {
> cpu_fprintf(f, "r%2.2d=%8.8x ", i, env->regs[i]);
> - if ((i + 1) % 4 == 0)
> + if (QEMU_IS_ALIGNED(i + 1, 4)) {
> cpu_fprintf(f, "\n");
> }
> + }
> cpu_fprintf(f, "\n\n");
> }
>
> --
> 2.13.2
>
>
--
Marc-André Lureau
[Qemu-trivial] [PATCH 27/29] tests/hbitmap: use ARRAY_SIZE macro, Philippe Mathieu-Daudé, 2017/07/18
[Qemu-trivial] [PATCH 28/29] tests/qapi: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
[Qemu-trivial] [PATCH 29/29] tests/qapi: use ARRAY_SIZE macro, Philippe Mathieu-Daudé, 2017/07/18
Message not available
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 15/29] microblaze: use QEMU_IS_ALIGNED macro,
Marc-André Lureau <=