[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 00/34] remove i386/pc dependency from non-PC w
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-trivial] [PATCH 00/34] remove i386/pc dependency from non-PC world (part 1) |
Date: |
Mon, 16 Oct 2017 22:44:40 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
This was an old(ish) patchset. Aplying it now.
22.09.2017 18:39, Philippe Mathieu-Daudé wrote:
> Hi,
>
> quite a bunch of patches and files modified, but the diffstat is not that big.
>
> First part is from clean-includes script,
> Then comes code movement, about no logical changes.
>
> Now some non-x86 builds and cocci spatch run a bit faster :)
>
> I updated some MAINTAINERS entries while here.
>
> Also I couldn't test the KVM/XEN/HAX part.
>
> Regards,
>
> Phil.
>
> Philippe Mathieu-Daudé (34):
> hw: use "qemu/osdep.h" as first #include in source files
applied
> hw: remove "qemu/osdep.h" from header files
not applied, doing two things, suggested split-up
(I'm fine with it as it is)
> block: remove "qemu/osdep.h" from header file
applied
> misc: remove headers implicitly included
applied
> misc: remove duplicated includes
applied
> ppc: remove duplicated includes
applied
> i386/hax: remove duplicated includes
applied (note it can be trimmed more)
> nios2: remove duplicated includes
applied
> misc: avoid "include/" in include path
not applied, probably should be split, but I'm fine with it as it is
> amd_iommu: avoid needless includes in header file
applied
> i386/pc: use TYPE_PORT92
applied
> misc: remove old i386 dependency
applied
> hw/ide: remove old i386 dependency
applied
> hw/ipmi: remove old i386 dependency
applied
> hw/i2c: remove old i386 dependency
applied
> hw/tpm: remove old i386 dependency
applied
> hw/virtio-balloon: remove old i386 dependency
applied
> hw/unicore32: restrict hw addr defines to source file
applied
> hw/acpi: ACPI_PM_* defines are not restricted to i386 arch
applied
> hw/timer/i8254: rename pit_init() -> i8254_pit_init()
not applied, split?
> hw/display/vga: remove the old i386/pc dependency
somehow I can't find this patch, neither in my inbox nor in patchwork
> hw/input/i8042: extract API from hw/i386/pc.h
CHECK
> hw/dma/i8257: rename DMA_init() to i8257_dma_init()
not applied, pending **errp addition
> hw/timer/mc146818: rename rtc_init() -> mc146818_init()
applied
> hw/timer/m48t59: use TYPE_M48T59_ISA, add entries to MAINTAINERS
not applied, it went out of context without i8257_dma_init rename
btw, why do we prefer these TYPE_XXX things instead of simple "xxx" stuff?
> hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c
applied
> hw/pci: declare pci_nic_init_nofail() in "hw/net/pci.h"
not applied, it does more than mentioned
> hw/net/e1000: use TYPE_PCI_E1000
> hw/net/e1000e: use TYPE_PCI_E1000E
> hw/net/pcnet: use TYPE_PCI_PCNET
> hw/net/rtl8139: use TYPE_PCI_RTL8139
> hw/net/ne2000: use TYPE_PCI_NE2000
Not applied, at least not yet, why do we use these TYPE_XX stuff to
start with?
> hw/alpha: remove old i386 dependency
not applied
> misc: drop old i386 dependency
applied, except of the MAINTAINERS part.
Applying these series is quite a bit boring task I'd say :)
Thanks,
/mjt
- Re: [Qemu-trivial] [PATCH 00/34] remove i386/pc dependency from non-PC world (part 1),
Michael Tokarev <=