Re: [Qemu-trivial] [Qemu-arm] [PATCH] arm/translate-a64: mark path as unreachable to eliminate warning

[Peter Maydell]

On 8 November 2017 at 12:37, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 11/07/2017 05:46 PM, Emilio G. Cota wrote:
>> Fixes the following warning when compiling with gcc 5.4.0 with -O1
>> optimizations and --enable-debug:
>>
>> target/arm/translate-a64.c: In function ‘aarch64_tr_translate_insn’:
>> target/arm/translate-a64.c:2361:8: error: ‘post_index’ may be used 
>> uninitialized in this function [-Werror=maybe-uninitialized]
>>      if (!post_index) {
>>         ^
>> target/arm/translate-a64.c:2307:10: note: ‘post_index’ was declared here
>>      bool post_index;
>>           ^
>> target/arm/translate-a64.c:2386:8: error: ‘writeback’ may be used 
>> uninitialized in this function [-Werror=maybe-uninitialized]
>>      if (writeback) {
>>         ^
>> target/arm/translate-a64.c:2308:10: note: ‘writeback’ was declared here
>>      bool writeback;
>>           ^
>>
>> Note that idx comes from selecting 2 bits, and therefore its value
>> can be at most 3.
>>
>> Signed-off-by: Emilio G. Cota <address@hidden>

Applied to target-arm.next, thanks. (It's a bit sad that
gcc can't figure out that the result of x & 3 is constrained
to [0,3], but there you go.)

> Acked-by: Philippe Mathieu-Daudé <address@hidden>

By the way, Philippe, what are you intending to convey with
an acked-by tag? Usually "acked-by" means "I'm the maintainer
for this area and I haven't actually reviewed this but I don't
object to it"...

thanks
-- PMM