[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 2/4] error: Remove NULL checks on error_propag
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-trivial] [PATCH 2/4] error: Remove NULL checks on error_propagate() calls |
|
Date: |
Mon, 26 Mar 2018 10:40:42 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 23/03/2018 21:50, Eric Blake wrote:
> On 03/22/2018 11:12 AM, Laurent Vivier wrote:
>> Re-run Coccinelle patch
>> scripts/coccinelle/error_propagate_null.cocci
>>
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
>> io/channel-websock.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>
> Misses an offender in numa.c, why?
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06382.html
>
No, error_report_err() doesn't check if err is NULL, we must check
before calling it.
Thanks,
Laurent