[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH trivial for-2.12] Makefile: install gtk messag
Re: [Qemu-trivial] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m
Mon, 16 Apr 2018 12:37:49 +0300
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0
16.04.2018 12:26, Peter Maydell wrote:
> On 14 April 2018 at 15:27, Michael Tokarev <address@hidden> wrote:
>> -ifeq ($(CONFIG_GTK),m)
>> +ifneq ($(filter $(CONFIG_GTK),y m),)
>> $(MAKE) -C po $@
> "trivial" and "for 2.12" don't make much sense together at this point in
> the release cycle. Is this important enough to go into rc4, or not?
Well, without this, gtk translations wont be installed. Not a huge issue,
especially for the languages where qemu lacks translations, but I still
think it is important enough to go to 2.12, or else it'll be a regression.
I've just sent another, simpler version of the same thing.