[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 13/15] hw/alpha/typhoon: Remo
From: |
Thomas Huth |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 13/15] hw/alpha/typhoon: Remove unuseful code |
Date: |
Tue, 2 Oct 2018 10:34:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-10-02 00:09, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/alpha/typhoon.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c
> index d74b5b55e1..8004afe45b 100644
> --- a/hw/alpha/typhoon.c
> +++ b/hw/alpha/typhoon.c
> @@ -932,23 +932,10 @@ PCIBus *typhoon_init(ram_addr_t ram_size, ISABus
> **isa_bus,
> return b;
> }
>
> -static int typhoon_pcihost_init(SysBusDevice *dev)
> -{
> - return 0;
> -}
> -
> -static void typhoon_pcihost_class_init(ObjectClass *klass, void *data)
> -{
> - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
> -
> - k->init = typhoon_pcihost_init;
> -}
> -
> static const TypeInfo typhoon_pcihost_info = {
> .name = TYPE_TYPHOON_PCI_HOST_BRIDGE,
> .parent = TYPE_PCI_HOST_BRIDGE,
> .instance_size = sizeof(TyphoonState),
> - .class_init = typhoon_pcihost_class_init,
> };
>
> static void typhoon_iommu_memory_region_class_init(ObjectClass *klass,
As far as I can see, this should be fine.
Reviewed-by: Thomas Huth <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 13/15] hw/alpha/typhoon: Remove unuseful code,
Thomas Huth <=