[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [PATCH] configure: add compat symlinks for cp and md5sum
From: |
Jean Delvare |
Subject: |
Re: [Quilt-dev] [PATCH] configure: add compat symlinks for cp and md5sum |
Date: |
Mon, 20 Jan 2014 08:52:42 +0100 |
Hi Kent,
On Sun, 19 Jan 2014 15:41:23 -0600, Kent R. Spillner wrote:
> Allow distributors to provide compat symlinks for cp and md5sum on
> non-GNU systems. md5sum is used by quilt/scripts/inspect and is
> provided by GNU coreutils, but may be installed as gmd5sum on some
> systems (e.g. OpenBSD). quilt/scripts/backup-files invokes cp
> with some non-portable GNU-specific command line arguments
> (e.g. --parents --remove-destination --target-directory).
>
> Original diff from Jérémie Courrèges-Anglas <address@hidden> on
> OpenBSD ports mailing list.
>
> Reported-by: Jérémie Courrèges-Anglas <address@hidden>
> Signed-off-by: Kent R. Spillner <address@hidden>
> ---
> Makefile.in | 2 ++
> configure.ac | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/Makefile.in b/Makefile.in
> index 8040653..0b8092b 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -42,6 +42,8 @@ MSGCAT := @MSGCAT@
> DIFFSTAT := @DIFFSTAT@
> RPMBUILD := @RPMBUILD@
> SENDMAIL := @SENDMAIL@
> +CP := @CP@
> +MD5SUM := @MD5SUM@
>
> USE_NLS := @USE_NLS@
> STAT_HARDLINK := @STAT_HARDLINK@
> diff --git a/configure.ac b/configure.ac
> index b181dcf..09f270a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -367,6 +367,9 @@ fi
>
> QUILT_COMPAT_PROG_PATH(SENDMAIL, sendmail, [], [/usr/sbin])
>
> +QUILT_COMPAT_PROG_PATH(CP, cp, [gcp cp])
> +QUILT_COMPAT_PROG_PATH(MD5SUM, md5sum, [gmd5sum md5sum])
This is fine for md5sum, but not for cp. On some systems gcp is
something different, for example:
http://packages.debian.org/wheezy/gcp
So you don't want to pick gcp and use it by default. You only want to
allow the user to pass --with-cp=/path/to/gcp. The following should do
exactly that:
QUILT_COMPAT_PROG_PATH(CP, cp)
> +
> AC_PATH_PROG(MSGMERGE, [msgmerge])
> AC_PATH_PROG(MSGFMT, [msgfmt])
> AC_PATH_PROG(XGETTEXT, [xgettext])
Thanks,
--
Jean Delvare
Suse L3 Support
- [Quilt-dev] [PATCH] configure: add compat symlinks for cp and md5sum, Kent R. Spillner, 2014/01/19
- [Quilt-dev] [PATCH] configure: add compat symlinks for cp and md5sum, Kent R. Spillner, 2014/01/19
- Re: [Quilt-dev] [PATCH] configure: add compat symlinks for cp and md5sum,
Jean Delvare <=
- Re: [Quilt-dev] [PATCH] configure: add compat symlinks for cp and md5sum, Kent R. Spillner, 2014/01/20
- Re: [Quilt-dev] [PATCH] configure: add compat symlinks for cp and md5sum, Jean Delvare, 2014/01/20
- [Quilt-dev] [PATCH v2] configure: add compat symlinks for cp and md5sum, Kent R. Spillner, 2014/01/20
- Re: [Quilt-dev] [PATCH v2] configure: add compat symlinks for cp and md5sum, Martin Quinson, 2014/01/21
- Re: [Quilt-dev] [PATCH v2] configure: add compat symlinks for cp and md5sum, Kent R. Spillner, 2014/01/21