quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] [PATCH] clean up the quilt man page


From: G. Branden Robinson
Subject: Re: [Quilt-dev] [PATCH] clean up the quilt man page
Date: Fri, 1 Jun 2018 07:35:33 -0400
User-agent: NeoMutt/20170113 (1.7.2)

At 2018-06-01T13:11:40+0200, Andreas Grünbacher wrote:
> Branden,

Hi Andreas!

> I'm not going to jump ahead of Jean who has been maintaining quilt the
> last couple of years, but thanks, your changes look like an
> improvement. The patch is somewhat difficult to review because it
> mixes formatting and content changes, so that may take a while.

I like focused changesets as much as anyone (it's one of the things
quilt facilitates marvelously), but this turned out to be a monolith
because I had no idea when I started how much I was going to be
changing.

I'm happy to break this into chunks if that would ease review, but I'd
like some feedback on how finely to chop it.

The changes I can think of that do the most to obscure others are:

> > * Eliminate empty lines; they are bad *roff style.

> > * Break lines after sentences.  In many cases, only a single space was
> >   used between sentences, which leads to incorrect inter-sentence
> >   spacing in all *roff output formats.  Two spaces are better (because
> >   groff recognizes them as separating sentences, but line breaks are the
> >   best style.

> > * Reorganize sections to use only section names endorsed by
> >   man-pages(7), and put them in the recommended order.

It would be straightforward for me to prepare 1-3 patches that perform
the above; I think all the other changes could be more easily reviewed
even as remaining "monolith".

Suggestions?

-- 
Regards,
Branden

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]