[Rdiff-backup-bugs] [bug #25684] Lost ownership data even when using --preserve-numerical-ids option

[anonymous]

Follow-up Comment #2, bug #25684 (project rdiff-backup):

More on this. I do not know nothin about Python -or too less that can be
called "nothing"- but I'm a bit concerned about this grep:

address@hidden:/usr/share/python-support/rdiff-backup/rdiff_backup$ ls
total 496
drwxr-xr-x 2 root root  4096 2008-06-17 22:33 .
drwxr-xr-x 3 root root  4096 2008-06-17 22:33 ..
-rw-r--r-- 1 root root 26566 2008-01-03 16:36 backup.py
-rw-r--r-- 1 root root  9528 2008-01-03 16:36 compare.py
-rw-r--r-- 1 root root 17780 2008-01-03 16:36 connection.py
-rw-r--r-- 1 root root 18700 2008-01-03 16:36 eas_acls.py
-rw-r--r-- 1 root root  8441 2008-01-03 16:36 FilenameMapping.py
-rw-r--r-- 1 root root 27297 2008-01-03 16:36 fs_abilities.py
-rw-r--r-- 1 root root 10577 2008-01-03 16:36 Globals.py
-rw-r--r-- 1 root root  5104 2008-01-03 16:36 Hardlink.py
-rw-r--r-- 1 root root  2141 2008-01-03 16:36 hash.py
-rw-r--r-- 1 root root  3995 2008-01-03 16:36 increment.py
-rw-r--r-- 1 root root     0 2008-01-03 16:36 __init__.py
-rw-r--r-- 1 root root 13185 2008-01-03 16:36 iterfile.py
-rw-r--r-- 1 root root  6037 2008-01-03 16:36 lazy.py
-rw-r--r-- 1 root root  6741 2008-01-03 16:36 librsync.py
-rw-r--r-- 1 root root  9427 2008-01-03 16:36 log.py
-rw-r--r-- 1 root root  9637 2008-01-03 16:36 longname.py
-rw-r--r-- 1 root root 33362 2008-01-03 16:36 Main.py
-rw-r--r-- 1 root root  6864 2008-01-03 16:36 manage.py
-rw-r--r-- 1 root root 24442 2008-01-03 16:36 metadata.py
-rw-r--r-- 1 root root  4367 2008-01-03 16:36 Rdiff.py
-rw-r--r-- 1 root root 13401 2008-01-03 16:36 regress.py
-rw-r--r-- 1 root root 26618 2008-01-03 16:36 restore.py
-rw-r--r-- 1 root root  4694 2008-01-03 16:36 robust.py
-rw-r--r-- 1 root root 11162 2008-01-03 16:36 rorpiter.py
-rw-r--r-- 1 root root 45992 2008-01-03 16:36 rpath.py
-rw-r--r-- 1 root root  9695 2008-01-03 16:36 Security.py
-rw-r--r-- 1 root root 26512 2008-01-03 16:36 selection.py
-rw-r--r-- 1 root root  8788 2008-01-03 16:36 SetConnections.py
-rw-r--r-- 1 root root  1424 2008-01-03 16:36 static.py
-rw-r--r-- 1 root root 14496 2008-01-03 16:36 statistics.py
-rw-r--r-- 1 root root  2454 2008-01-03 16:36 TempFile.py
-rw-r--r-- 1 root root  8595 2008-01-03 16:36 Time.py
-rw-r--r-- 1 root root  6772 2008-01-03 16:36 user_group.py

I think here's all the python stuff of rfidd_backup on my distro, with
the exception of /usr/bin/rdiff-backup that directly uses Main.py. So...



There's just an assigment of 1 to the flag preserve_numerical_ids but
it's not used for nothing nowhere! O_o

address@hidden:/usr/share/python-support/rdiff-backup/rdiff_backup$
grep preserve-numerical-ids *
Main.py:                  "preserve-numerical-ids", "print-statistics",
Main.py:                elif opt == "--preserve-numerical-ids":
preserve_numerical_ids = 1
address@hidden:/usr/share/python-support/rdiff-backup/rdiff_backup$
grep preserve_numerical_ids *
Main.py:user_mapping_filename, group_mapping_filename,
preserve_numerical_ids = 
Main.py:                   preserve_numerical_ids
Main.py:                elif opt == "--preserve-numerical-ids":
preserve_numerical_ids = 1
Main.py:                   preserve_numerical_ids
Main.py:                                                                     
                           
preserve_numerical_ids)
Main.py:                                                                     
                            
preserve_numerical_ids)


I expect to find some kind of "if" structure using that flag in some
other files -like backup.py and/or restore.py- but it isn't there, so I
think that option actually has no effect.


JFTR:
$ rdiff-backup --version
rdiff-backup 1.1.15

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?25684>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/