[rdiff-backup-users] pyxattr on OSs without xattr support

[John Goerzen]

Hello,

On Alpha, when I tried rdiff-backup when the .deb was built with support
for pyxattr, I got:

IOError: [Errno 78] Function not implemented

on Alpha.

So I have been making sure that rdiff-backup on Debian does not use
xattr/ACL support.  However, those are nice features to have.

Would it be possible to have a runtime check to make sure the host OS
supports xattrs and ACLs prior to trying to use them?

Specifically, I look at this code in fs_abilities.py:

                try:
                        xattr.listxattr(rp.path)
                        if write:
                                xattr.setxattr(rp.path, "user.test", "test val")
                                assert xattr.getxattr(rp.path, "user.test") == "
test val"
                except IOError, exc:
                        if exc[0] == errno.EOPNOTSUPP:
                                log.Log("Extended attributes not supported by "
                                                "filesystem at %s" % (rp.path,),
 4)
                                self.eas = 0
                        else: raise

I think that the else should not do a raise but should set eas to 0.
Or, to put it another way, exc[0] should not be tested.


-- John