[rdiff-backup-users] rdiff-backup on windows

[Rui Lopes]

Hi,

I'm trying to use rdiff-backup on windows through cygwin, but it failed 
with this:

$ rdiff-backup --windows-mode orig backup
Traceback (most recent call last):
  File "/usr/bin/rdiff-backup", line 23, in ?
    rdiff_backup.Main.Main(sys.argv[1:])
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 
254, in Main
    take_action(rps)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 
226, in take_action
    elif action == "backup": Backup(rps[0], rps[1])
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 
266, in Backup
    rpout.conn.Main.backup_touch_curmirror_local(rpin, rpout)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 
366, in backup_touch_
curmirror_local
    mirrorrp.fsync_with_dir()
  File "/usr/lib/python2.3/site-packages/rdiff_backup/rpath.py", line 
919, in fsync_with_d
ir
    self.fsync(fp)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/rpath.py", line 
907, in fsync
    if not fp: self.conn.rpath.RPath.fsync_local(self)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/rpath.py", line 
914, in fsync_local
    os.fsync(fd)
OSError: [Errno 13] Permission denied
Exception exceptions.TypeError: "'NoneType' object is not callable" in 
<bound method GzipF
ile.__del__ of <gzip open file 
'backup/rdiff-backup-data/error_log.2004-06-29;08400;05830;
05815;090.data.gz', mode 'wb' at 0xa1472e0 0xa2198cc>> ignored


It seems that on windows we need to open the file RW to be able to fsync 
it, see attached patch.


Can't rdiff-backup automatically set '--windows-mode' when run in a 
windows envirnoment?  and maybe have this setting saved in the metadata?


Best regards,
Rui Lopes

--- rpath.py.orig       2004-06-29 00:26:04.156250000 +0100
+++ rpath.py    2004-06-29 00:27:13.187500000 +0100
@@ -910,7 +910,7 @@
        def fsync_local(self):
                """fsync current file, run locally"""
                assert self.conn is Globals.local_connection
-               fd = os.open(self.path, os.O_RDONLY)
+               fd = os.open(self.path, os.O_RDWR)
                os.fsync(fd)
                os.close(fd)