Re: [rdiff-backup-users] [PATCH] Log symlink creation

[Gordon Rowell]

dean gaudet wrote:

> [...]
>
> yeah it would be desirable to store the symlink info in the metadata.  
> and desirable to add an fs_abilities test for symlink capabilities...
>  

Yep, that was my plan.

> i wasn't sure about your patch -- it just adds more logging?
>
>  

At verbose level 6. Compare with the other functions nearby - all of the 
other fs ops can log, but this was missing for symlink ops. Adding this 
localises the traceback for the failed symlink operation and makes it 
obvious that the filesystem doesn't support it.

Thanks,

Gordon