[Savannah-help-public] Re: log_accum

[Derek R. Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sylvain Beucler wrote:
> - temporary files clean-up: the regexp does not match the files, and
>   does not delete them. I tried fixing it, but I get a weird 'perl -T'
>   warning..

Anything read from the file system or the command line is considered
tainted in perl's taint mode and when a tainted var is passed to a
system function (like unlink), perl aborts.  Since the grep was matching
nothing, @files was empty, and the fact that I neglected to untaint the
output of readdir before passing it to unlink went unnoticed.  When you
fixed the regexp, perl noticed the taint and aborted...

Anyhow, I fixed this.

> - no mail notification when the user did not enter a log message

Simple fix - write_file() was not creating the temp files when it was
passed an empty array.  This behavior wasn't needed anywhere, so I've
fixed it.

> - in the attached patch, I shortened the credits part, refering people
>   to ChangeLog

Installed.

I also noticed a bug where, when files are committed in multiple
subdirectories of the top level, but no files are committed from the top
level (like lib/stdint_.h, m4/stdint.m4), then a slash was missing from
files in the first directory in the subject line (like "ccvs
libstdint_.h m4/stdint.m4").  I've installed a fix for this.

Regards,

Derek
- --
Derek R. Price
CVS Solutions Architect
Get CVS support at Ximbiot <http://ximbiot.com>!
v: +1 248.835.1260
f: +1 248.835.1263
<mailto:address@hidden>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEoJLTLD1OTBfyMaQRAtr0AKCbCiP98PNH8ReMiCuEFO1FjYZkvACg/PE4
jOfHSOg8+zSZqQyn8I4ffQQ=
=lo84
-----END PGP SIGNATURE-----