[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Savannah-register-public] Re: Fwd: [task #7064] Submission of qemuGL

From: Sylvain Beucler
Subject: [Savannah-register-public] Re: Fwd: [task #7064] Submission of qemuGL
Date: Mon, 10 Sep 2007 23:15:18 +0200
User-agent: Mutt/1.5.13 (2006-08-11)


I don't like what he says. He says that at qemu they don't track
authors per file and that it's ok. But at Savannah, we are here to
teach recommended copyright good practices - we're teachers, not
students ;)

So I think he needs to modify files that are non-trivially changed (if
he modified a couple lines, no problem, but if the change is
consequent (is it?) then he needs to add his copyright notice). The
goal is that when I copy code from a project, I copy the file's
copyright notices along.

What do you think?


On Mon, Sep 10, 2007 at 11:15:33PM +0300, Alexander Shulgin wrote:
> Hi,
> the copyright notices look OK to me, finally.  If there are no other
> issues--I didn't see any, the project might be approved now.  :-)
> Alex
> PS: thanks for your patience with me.
> ---------- Forwarded message ----------
> From: Even Rouault <address@hidden>
> Date: Sep 9, 2007 1:13 AM
> Subject: [task #7064] Submission of qemuGL
> To: Alexander Shulgin <address@hidden>, Even Rouault
> <address@hidden>, address@hidden
> Follow-up Comment #3, task #7064 (project administration):
> Hi,
> there was already my copyright notice in opengl_client_xfonts.c. I just moved
> it at the beginning of the file if it makes things clearer...
> I added one for opengl_utils.h and as well, but I feel a
> bit ridiculous adding a copyright notice on a shell file...and that is only
> meant to work on my PC!
> For kqemu.c, I really don't think it's neccesary. If you look closely at what
> happens on qemu devel list, you'll see that it is not common practice in qemu
> development to add your name each time you modify an existing file. Otherwise
> you'll have hundred lines of names for each file! The general rule is that
> there is the name of the author of the file, and additional names for authors
> of really big changes.
> I've done these changes on a slighly improved version that adds thread
> safety. This patch should apply cleanly on recent CVS snapshot
> Regards
> Even
> (file #13900)
>     _______________________________________________________
> Additional Item Attachment:
> File name: qemu_cvs20070907_opengl_patch_20070908.patch.tar.bz2 Size:205 KB
>     _______________________________________________________
> Reply to this item at:
>   <>
> _______________________________________________
>   Message posté via/par Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]