sed-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tests


From: Jim Meyering
Subject: Re: tests
Date: Fri, 3 Jun 2016 22:15:02 -0700

On Fri, Jun 3, 2016 at 6:45 PM, Assaf Gordon <address@hidden> wrote:
> Hello,
>
> Attached are the three remaining tests, now pass on all common OSes
> ( 'printf' on older BSD system only supports octal values and not hex values, 
> bash's 'test' on AIX emulates /dev/stderr which doesn't exist).
>
> Also attached is a new test for '--follow-symlinks'.
> This updated patch adds the tests conditionally (if "follow symlinks" is 
> supported) using AM_CONDITIONAL in ./configure.ac .  I hope this is the 
> correct approach (but haven't tested it on system lacking symlinks yet).

Thanks for still more tests.
I don't have time for the full review today, but may have spotted a
nit. Is this normalize-text.sh comment obsolete, because the bug it
refers to is the one you fixed recently?

+# \cX combination
+# TODO: '\c\\' not tested yet (until the bug is fixed)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]