|
From: | Kamil Shakirov |
Subject: | Re: [STUMP] [PATCH] Add support for LispWorks 6 in 'mpd.lisp' module. |
Date: | Mon, 29 Oct 2012 00:31:42 +0700 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 |
Hi Dirk, On 10/29/2012 12:02 AM, Dirk Sondermann wrote:
On 10/28/12 01:55, Shawn Betts wrote:On Sat, Oct 27, 2012 at 1:19 AM, Dirk Sondermann wrote:On 10/26/12 20:54, Shawn Betts wrote:Thanks Kamil. Can someone confirm that it still works on clisp and sbcl?It builds and works on SBCL.Good enough for me. Thanks! Kamil, it's been merged.Unfortunately, I missed an issue while testing the mpd module on SBCL yesterday. In the function MPD-RECEIVE, the symbol READ-LINE is used as the name of a function defined by FLET. By default, SBCL locks the package COMMON-LISP, to which READ-LINE belongs, so binding this symbol by FLET leads to an error: caught ERROR: Lock on package COMMON-LISP violated when binding READ-LINE as a local function while in package STUMPWM. See also: The SBCL Manual, Node "Package Locks" The ANSI Standard, Section 11.1.2.1.2
Ooops. :)Hmm, CLisp, Clozure CL, Allegro CL and LispWorks do not signal an error if FLET shadows a global function (from CL package in this case).
In principle, one could avoid this error by unlocking the package (I did that accidentally yesterday by using SB-EXT:UNLOCK-PACKAGE somewhere in my ~/.stumpwmrc), but it seems to be better to replace READ-LINE with a less controversial name (cf. the attached patch). _______________________________________________ Stumpwm-devel mailing list address@hidden https://lists.nongnu.org/mailman/listinfo/stumpwm-devel
-- --ska.
[Prev in Thread] | Current Thread | [Next in Thread] |