texinfo-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[7803] info_search_in_node_internal call free_matches


From: gavinsmith0123
Subject: [7803] info_search_in_node_internal call free_matches
Date: Sat, 20 May 2017 11:47:00 -0400 (EDT)

Revision: 7803
          http://svn.sv.gnu.org/viewvc/?view=rev&root=texinfo&revision=7803
Author:   gavin
Date:     2017-05-20 11:47:00 -0400 (Sat, 20 May 2017)
Log Message:
-----------
info_search_in_node_internal call free_matches

Modified Paths:
--------------
    trunk/ChangeLog
    trunk/info/session.c

Modified: trunk/ChangeLog
===================================================================
--- trunk/ChangeLog     2017-05-20 13:44:26 UTC (rev 7802)
+++ trunk/ChangeLog     2017-05-20 15:47:00 UTC (rev 7803)
@@ -1,5 +1,11 @@
 2017-05-20  Gavin Smith  <address@hidden>
 
+       * info/session.c (info_search_in_node_internal): Call
+       free_matches even after a failing search in order to avoid a 
+       memory leak.
+
+2017-05-20  Gavin Smith  <address@hidden>
+
        * NEWS (info): Add items about setting style variables and 
        --vi-keys.
 

Modified: trunk/info/session.c
===================================================================
--- trunk/info/session.c        2017-05-20 13:44:26 UTC (rev 7802)
+++ trunk/info/session.c        2017-05-20 15:47:00 UTC (rev 7803)
@@ -3923,7 +3923,6 @@
       || window->search_is_case_sensitive != case_sensitive)
     {
       free_matches (&window->matches);
-
       free (window->search_string);
       window->search_string = xstrdup (string);
       window->search_is_case_sensitive = case_sensitive;
@@ -3937,7 +3936,10 @@
     }
   
   if (result != search_success)
-    return result;
+    {
+      free_matches (&matches);
+      return result;
+    }
 
   if (node->flags & N_Simple)
     {




reply via email to

[Prev in Thread] Current Thread [Next in Thread]