texinfo-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[8104] parsetexi valgrind fixes


From: gavinsmith0123
Subject: [8104] parsetexi valgrind fixes
Date: Sat, 18 Aug 2018 09:04:39 -0400 (EDT)

Revision: 8104
          http://svn.sv.gnu.org/viewvc/?view=rev&root=texinfo&revision=8104
Author:   gavin
Date:     2018-08-18 09:04:38 -0400 (Sat, 18 Aug 2018)
Log Message:
-----------
parsetexi valgrind fixes

Modified Paths:
--------------
    trunk/tp/Texinfo/XS/parsetexi/end_line.c
    trunk/tp/Texinfo/XS/parsetexi/parser.c
    trunk/tp/Texinfo/XS/parsetexi/tree.c

Modified: trunk/tp/Texinfo/XS/parsetexi/end_line.c
===================================================================
--- trunk/tp/Texinfo/XS/parsetexi/end_line.c    2018-08-18 11:35:36 UTC (rev 
8103)
+++ trunk/tp/Texinfo/XS/parsetexi/end_line.c    2018-08-18 13:04:38 UTC (rev 
8104)
@@ -1819,6 +1819,7 @@
 
       if (current->cmd != CM_top && misc_content->contents.number == 0)
         {
+          destroy_element (misc_content);
           command_warn (current, "@%s missing argument", 
                         command_name(current->cmd));
           add_extra_integer (current, "missing_argument", 1);

Modified: trunk/tp/Texinfo/XS/parsetexi/parser.c
===================================================================
--- trunk/tp/Texinfo/XS/parsetexi/parser.c      2018-08-18 11:35:36 UTC (rev 
8103)
+++ trunk/tp/Texinfo/XS/parsetexi/parser.c      2018-08-18 13:04:38 UTC (rev 
8104)
@@ -476,7 +476,6 @@
       if (last_child->text.end == 0) //2121
         {
           e = pop_element_from_contents (current);
-          e->parent = 0; e->parent_type = route_not_in_tree;
           destroy_element (e);
           /* TODO: Maybe we could avoid adding it in the first place? */
 
@@ -511,7 +510,6 @@
               owning_keypair->value = 0;
               owning_keypair->type = extra_deleted;
             }
-          e->text.text = 0;
           destroy_element (e);
         }
       retval = 1;

Modified: trunk/tp/Texinfo/XS/parsetexi/tree.c
===================================================================
--- trunk/tp/Texinfo/XS/parsetexi/tree.c        2018-08-18 11:35:36 UTC (rev 
8103)
+++ trunk/tp/Texinfo/XS/parsetexi/tree.c        2018-08-18 13:04:38 UTC (rev 
8104)
@@ -61,8 +61,15 @@
       switch (e->extra[i].type)
         {
         case extra_string:
+        case extra_index_entry:
           free (e->extra[i].value);
           break;
+        case extra_element_contents:
+          destroy_element ((ELEMENT *) e->extra[i].value);
+          break;
+        case extra_element_contents_array:
+          /* TODO */
+          break;
         default:
           /* TODO: need to check if the element is in the main tree or not. */
           break;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]