|
From: | Domingo Alvarez Duarte |
Subject: | Re: [Tinycc-devel] Small patch |
Date: | Thu, 31 Jan 2013 12:41:01 +0000 |
This is counterproductive IMO because when you read this you get
- h = elf_hash(name) % nbuckets;
+ h = name ? elf_hash(name) % nbuckets : 0;
the wrong impression that there are cases where "name" is NULL.
But in fact there is no such case. So the naive reader is misled,
while the knowledgeable reader must conclude that the writer didn't
know what s/he was doing.
[Prev in Thread] | Current Thread | [Next in Thread] |