Re: [Tinycc-devel] isxdigit conversion inconsistency with widechar

[Carlos Montiers]

2014-06-30 10:45 GMT-04:00 Thomas Preud'homme <address@hidden>:

Le dimanche 29 juin 2014, 22:10:01 Carlos Montiers a écrit :

> Hello.
> Currently, in the last version (from git) of tiny c, when you use the
> function:
>
> isxdigit it produce this call: isxdigit
>
> but when you use the widechar version: iswxdigit :
>
> iswxdigit produce this call: iswctype(d, _HEX)
>
> Then, when you use isxdigit tiny c would be generate the call to:
> _isctype(d, _HEX)

Not very consistent I agree but how is that a bug?

Best regards,

Thomas
_______________________________________________
Tinycc-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

Yes. It is not a bug. But, I post this for the knowledge. I inspect mscvrt.dll and isxdigit internally call to _isctype. Then I think is more speedy call directly to _isctype instead of isxdigit. But the current macro of tiny c not call to it like the counterpart iswxdigit. Because it I post my little fix:

#undef        isxdigit
#undef        iswxdigit
#define        isxdigit(d)      _isctype(d, _HEX)
#define        iswxdigit(d)    iswctype(d, _HEX)