[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Tinycc-devel] [PATCH 4/4] tcc.[ch]: Adjust code style.
From: |
Lee Duhem |
Subject: |
Re: [Tinycc-devel] [PATCH 4/4] tcc.[ch]: Adjust code style. |
Date: |
Thu, 27 Nov 2014 11:44:31 +0800 |
On Wed, Nov 26, 2014 at 7:54 PM, David Mertens <address@hidden> wrote:
> As for the order of value checking, I do not think this is a good idea.
> These are classic Yoda Conditions and they should be kept that way to
> encourage the practice, in my opinion.
>
I am fine with both of these styles, as long as one of them is adopted
consistently. Mixing them up randomly just too bad for my eyes.
It looks like the existing code already chose `var == const` style, I think
we should stick to it. If we decide to change to another style, that change
should be made globally.
Sincerely,
lee