Re: [Tinycc-devel] [PATCH] cpu detection

[Michael B. Smith]

I'm pretty sure this breaks Windows support.

-----Original Message-----
From: address@hidden [mailto:address@hidden On Behalf Of Sergey Korshunoff
Sent: Monday, January 5, 2015 11:51 AM
To: Thomas Preud'homme
Cc: address@hidden
Subject: Re: [Tinycc-devel] [PATCH] cpu detection

cpu detection v2
* don't setup a cpu before scanning for --cpu=
* if cpu="" then
     if ARCH != "" then cpu=$ARCH else cpu=`uname -m`
* if cpu="x86-64" and sizeof(long) = 4 then cpu="x86"


2015-01-04 19:37 GMT+03:00, Sergey Korshunoff <address@hidden>:
> As suggested on another forum, there is a "setarch linux32" command 
> for changing ARCH reported by "uname -m".
>
> 2015-01-04 2:45 GMT+03:00, Thomas Preud'homme <address@hidden>:
>> Le mardi 30 décembre 2014, 11:05:15 Sergey Korshunoff a écrit :
>>> Problem: configure in 32bit userspace running on 64bit kernel is 
>>> trying to compile tcc for ARCH=x86_64. Expecting behavior: to 
>>> configure a tcc for ARCH=x86
>>>
>>> This patch will allow to specify/configure a target cpu. Examples:
>>>       ARCH=x86 ./configure
>>>       ARCH=x86_64 ./configure
>>>
>>> If ARCH is not specified then try to detect a current cpu type by 
>>> examining arch of the host_cc.
>>
>> The principle is nice but the code style looks different from the 
>> rest and a
>>
>> bit complicated for what it is. Why using a subscript for instance? 
>> Why not
>>
>> nesting if?
>>
>> Finally, you could instead of using readelf use a carefully crafted 
>> conftest
>>
>> that would give you whether userspace is 32bit of 64bit. The 
>> structure would
>>
>> then look like this:
>>
>> if ARCH is defined, then use it
>> else use uname
>>
>> if cpu is x86_64 and conftest gives 32bit, cpu=i386.
>>
>> What do you think?
>>
>> Best regards,
>>
>> Thomas
>>
>