trans-coord/gnun/server/gnun ChangeLog GNUmakef...

[Yavor Doganov]

CVSROOT:        /sources/trans-coord
Module name:    trans-coord
Changes by:     Yavor Doganov <yavor>   08/06/12 09:32:08

Modified files:
        gnun/server/gnun: ChangeLog GNUmakefile TODO 

Log message:
        ($(rootdir)/home.$(1).shtml)
        ($(subst /po/,/,$(1).html)): Revert the embarrassing change from
        2008-05-27 and document the real culrprit.
        ($(template-dir)/po/whatsnew.%.html): Sleep for a second too if
        validation fails.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/trans-coord/gnun/server/gnun/ChangeLog?cvsroot=trans-coord&r1=1.83&r2=1.84
http://cvs.savannah.gnu.org/viewcvs/trans-coord/gnun/server/gnun/GNUmakefile?cvsroot=trans-coord&r1=1.43&r2=1.44
http://cvs.savannah.gnu.org/viewcvs/trans-coord/gnun/server/gnun/TODO?cvsroot=trans-coord&r1=1.13&r2=1.14

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/trans-coord/trans-coord/gnun/server/gnun/ChangeLog,v
retrieving revision 1.83
retrieving revision 1.84
diff -u -b -r1.83 -r1.84
--- ChangeLog   7 Jun 2008 20:17:46 -0000       1.83
+++ ChangeLog   12 Jun 2008 09:32:08 -0000      1.84
@@ -1,3 +1,11 @@
+2008-06-12  Yavor Doganov  <address@hidden>
+
+       * GNUmakefile ($(rootdir)/home.$(1).shtml)
+       ($(subst /po/,/,$(1).html)): Revert the embarrassing change from
+       2008-05-27 and document the real culrprit.
+       ($(template-dir)/po/whatsnew.%.html): Sleep for a second too if
+       validation fails.
+
 2008-06-07  Yavor Doganov  <address@hidden>
 
        * GNUmakefile (vcs-add-always): Add $(gnunews) to the list of
@@ -5,7 +13,8 @@
 
 2008-06-06  Yavor Doganov  <address@hidden>
 
-       * gnun.mk (server): Add `tasks', requested by _xavi.
+       * gnun.mk (server): Add `tasks'.
+       Requested by Xavier Reina.
 
 2008-06-06  Andrea Pescetti  <address@hidden>  (tiny change)
 

Index: GNUmakefile
===================================================================
RCS file: /sources/trans-coord/trans-coord/gnun/server/gnun/GNUmakefile,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -b -r1.43 -r1.44
--- GNUmakefile 7 Jun 2008 20:17:46 -0000       1.43
+++ GNUmakefile 12 Jun 2008 09:32:08 -0000      1.44
@@ -342,7 +342,7 @@
          $(template-dir)/po/whatsnew.$*.m4
        $(M4) $(template-dir)/po/whatsnew.$*.m4 > $@
        $(VALIDATESKIP) ./validate-html-notify $(NOTIFYSKIP) $(transl-addr) \
-         $@ || (sleep 2 ; touch $(template-dir)/po/whatsnew.$*.po ; exit 1)
+         $@ || (sleep 1 ; touch $(template-dir)/po/whatsnew.$*.po ; exit 1)
 # Copy the target where it belongs.
        cp $@ $(template-dir)
 ### End of the whatsnew-specific rules ###
@@ -396,8 +396,11 @@
          "s/\(<!--#include file=\"gnusflashes*\)\(.include\" 
-->\)/\1.$(1)\2/g" \
          $(rootdir)/po/home.$(1).m4
        $(M4) $(rootdir)/po/home.$(1).m4 > $$@
+# Touching the prerequisite does not help for the automatic build,
+# since `cvs commit' run from the cronjob after make modifies the
+# target and thus it becomes newer than the prerequisite.
        $(VALIDATESKIP) ./validate-html-notify $(NOTIFYSKIP) $(transl-addr) \
-         $$@ || (sleep 2 ; touch $(rootdir)/po/home.$(1).po ; exit 1)
+         $$@ || (sleep 1 ; touch $(rootdir)/po/home.$(1).po ; exit 1)
 endef
 
 $(foreach h-lang,$(HOME_LINGUAS),$(eval $(call home-rules,$(h-lang))))
@@ -459,7 +462,7 @@
        done
        $(M4) $(1).m4 > $$@
        $(VALIDATESKIP) ./validate-html-notify $(NOTIFYSKIP) $(transl-addr) \
-         $$@ || (sleep 2 ; touch $(1).po ; exit 1)
+         $$@ || (sleep 1 ; touch $(1).po ; exit 1)
 endef
 
 $(foreach base,$(ALL_BASE),$(eval $(call article-pot-rules,$(base))))

Index: TODO
===================================================================
RCS file: /sources/trans-coord/trans-coord/gnun/server/gnun/TODO,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -b -r1.13 -r1.14
--- TODO        1 Jun 2008 10:19:05 -0000       1.13
+++ TODO        12 Jun 2008 09:32:08 -0000      1.14
@@ -2,6 +2,19 @@
 
 * Present bugs
 
+** Rebuilding of the invalid XHTML files is not triggered.
+   When the build is invoked by a cronjob and an article fails fo
+   validate, next time it is not rebuilt.  The reason is that `cvs
+   commit' is run after make, and it unavoidably modifies the target
+   because of the $Date: 2008/06/12 09:32:08 $ keyword expansions.  Next time 
when make
+   compares the timestamps, article.LANG.html is newer than
+   article.LANG.po so it does not run the commands in the recipe.
+   Possible solution for this is 1) to use `at' to `touch' the
+   prerequisite in a defered manner; 2) Implement `hooks', i.e. let
+   make run commands which will create file(s) recording the
+   prerequisite that has to be touched, and build the `finalize'
+   target after `cvs commit'.
+
 ** #include directives propagate in the POT.
    This is fixed in Po4a 0.33.3 but there is another regression in
    this release: one or two blank lines are added before the first