Re: [VM] Announcement: VM 8.2.0b (beta-testing) release

[Ulrich Mueller]

>>>>> On Wed, 28 Dec 2011, Uday Reddy wrote:

> I managed to take some time off during the Christmas break to finish
> up the work leading up to the 8.2.0 version. I am doing a
> "beta-testing" release because there have been some significant
> changes since the last "alpha-testing" release.

Hi Uday,
Thanks for the great work. I'm about to package 8.2.0b for Gentoo
(it will be called app-emacs/vm-8.2.0_beta because of Gentoo naming
conventions [1]).

I've had some problems with path definitions:
- Variable vm-configure-docdir and vm-configure-infodir are both empty
  strings. Looks like their definition in lisp/Makefile.in is missing.
- The data files (NEWS etc.) are installed into etcdir, therefore
  vm-configure-datadir should be set to etcdir too. (One could think
  about renaming the lisp variable to vm-configure-etcdir. However, in
  the patch below I've chosen not to do this.)
The patch included below addresses these path issues.

Also I'm not too happy that the NEWS etc. files are installed twice,
in docdir and in etcdir. What do you think about installing them in
docdir only, but with docdir being equal to etcdir by default (as it's
the case for XEmacs already)? That way, distros could change the
default as needed (according to their policy), without installing
these files twice.

Cheers,
Ulrich

[1] <http://devmanual.gentoo.org/ebuild-writing/file-format/#file-naming-rules>


--- vm-8.2.0b-orig/lisp/Makefile.in
+++ vm-8.2.0b/lisp/Makefile.in
@@ -96,7 +96,10 @@
 datadir= @datadir@
 datarootdir= @datarootdir@
 lispdir = @lispdir@
+etcdir= @etcdir@
 pixmapdir= @pixmapdir@
+docdir = @docdir@
+infodir = @infodir@
 
 EMACS_PROG = @EMACS_PROG@
 EMACS_FLAVOR = @EMACS_FLAVOR@
@@ -137,7 +140,7 @@
         "$(EMACS_PROG)" $(FLAGS) -l autoload \
                -f vm-built-autoloads "@abs_builddir@/$@" "`pwd`")
        echo "(custom-add-load 'vm 'vm-cus-load)" | tr -d '\015' >> $@
-       echo "(setq vm-configure-datadir \"${datadir}/vm\")" | tr -d '\015' >> 
$@
+       echo "(setq vm-configure-datadir \"${etcdir}\")" | tr -d '\015' >> $@
        echo "(setq vm-configure-pixmapdir \"${pixmapdir}\")" | tr -d '\015' >> 
$@
        echo "(setq vm-configure-docdir \"${docdir}\")" | tr -d '\015' >> $@
        echo "(setq vm-configure-infodir \"${infodir}\")" | tr -d '\015' >> $@
@@ -168,7 +171,7 @@
        cat address@hidden >> $@
        echo "(setq features (delete 'vm-autoloads features))" >> $@
        echo "(require 'vm-vars)" >> $@
-       echo "(setq vm-configure-datadir \"${datadir}\")" >> $@
+       echo "(setq vm-configure-datadir \"${etcdir}\")" >> $@
        echo "(setq vm-configure-pixmapdir \"${pixmapdir}\")" >> $@
        $(RM) address@hidden