Re: [Wget-dev] wget2 | Fix progress display (issue #339) (!391)

[Darshit Shah]

Darshit Shah started a new discussion on libwget/bar.c:

>       _bar_slot_t *slotp = &bar->slots[slot];
>  
>       xfree(slotp->filename);
> -     slotp->filename = wget_strdup(filename);
> +     if (++slotp->numfiles == 1) {
> +         slotp->filename = wget_strdup(filename);
> +         slotp->bytes_downloaded = 0;
> +     } else {
> +         char tag[128];

Does it really need to 128 bytes large? The filename can be at most 20 chars. 
Then I guess, the tag can be made only chars large as well.

Also, why not simply do a `wget_snprintf` on `slotp->filename`? Or am I missing 
something here?

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/391#note_95080383
You're receiving this email because of your account on gitlab.com.