emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master e869ae2: Fix EBROWSE parsing of classes declared final.


From: Glenn Morris
Subject: Re: master e869ae2: Fix EBROWSE parsing of classes declared final.
Date: Thu, 03 Jan 2019 12:42:45 -0500
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Hi,

Re this:

> commit e869ae200db8378ab50957b8d357888e78fe0aac
>
>     Fix EBROWSE parsing of classes declared final.
> ---
>  ChangeLog.3       |  9 ++++++++
>  lib-src/ebrowse.c | 68 
> +++++++++++++++++++++++++++++++++++++++++++------------
>  2 files changed, 63 insertions(+), 14 deletions(-)
>
> diff --git a/ChangeLog.3 b/ChangeLog.3
> index decee10..df2b167 100644
> --- a/ChangeLog.3
> +++ b/ChangeLog.3
> @@ -1,3 +1,12 @@
> +2019-01-03  Andrey Kotlarski  <address@hidden>
> +
> +     Fix EBROWSE parsing of classes declared final
> +
> +     * lib-src/ebrowse.c (enum token, token_string, init_scanner):
> +     Handle final keyword.
> +     (member, class_definition, globals): Correctly determine class
> +     name in presence of final declaration.
> +

ChangeLogs are automatically generated files (since some time) and should
not be edited directly. Instead what you wrote in ChangeLog.3 should
have been the commit message. No big deal though. If you had written
that entry to the unversioned file "ChangeLog", log-edit-insert-changelog
(C-c C-a) would have inserted it into the vc-log buffer. This is covered
in CONTRIBUTE.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]