emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 0c9d31812f: Unbreak the build broken by tab-bar.el changes


From: Eli Zaretskii
Subject: master 0c9d31812f: Unbreak the build broken by tab-bar.el changes
Date: Mon, 24 Oct 2022 09:46:39 -0400 (EDT)

branch: master
commit 0c9d31812f91fcddb1d6626c26313cd45a661b5f
Author: Eli Zaretskii <eliz@gnu.org>
Commit: Eli Zaretskii <eliz@gnu.org>

    Unbreak the build broken by tab-bar.el changes
    
    Without this change, compiling tab-bar.el errors out:
    In tab-bar--load-buttons:
    tab-bar.el:161:18: Warning: reference to free variable `tab-bar-new'
    tab-bar.el:174:6: Error: `define-icon' defined after use in
    (define-icon tab-bar-close nil (cons (cons 'image
    (cons "tabs/close.xpm"
    (cons :margin (cons tab-bar-button-margin '(:ascent center)))))
    '((text " x"))) "Icon for closing the clicked tab."
    :version "29.1" :help-echo "Click to close tab")
    (missing `require' of a library file?)
    tab-bar.el:174:18: Warning: reference to free variable `tab-bar-close'
    * lisp/tab-bar.el (eval-when-compile): Require 'icons.
---
 lisp/tab-bar.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index ea615b92a2..9c746b8978 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -33,7 +33,8 @@
 
 (eval-when-compile
   (require 'cl-lib)
-  (require 'seq))
+  (require 'seq)
+  (require 'icons))
 
 
 (defgroup tab-bar nil
@@ -156,7 +157,6 @@ For easier selection of tabs by their numbers, consider 
customizing
 (defun tab-bar--load-buttons ()
   "Load the icons for the tab buttons."
   (require 'icons)
-
   (unless (iconp 'tab-bar-new)
     (define-icon tab-bar-new nil
       `((image "tabs/new.xpm"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]