emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 3e3f34d71e9 03/16: Fix ebrowse -f buffer overflow


From: Paul Eggert
Subject: master 3e3f34d71e9 03/16: Fix ebrowse -f buffer overflow
Date: Sun, 14 May 2023 22:28:24 -0400 (EDT)

branch: master
commit 3e3f34d71e9c3c6c943580dc822afed7a3b0a861
Author: Paul Eggert <eggert@cs.ucla.edu>
Commit: Paul Eggert <eggert@cs.ucla.edu>

    Fix ebrowse -f buffer overflow
    
    * lib-src/ebrowse.c (main): Fix buffer overflow when several -f
    options are given.  Found by GCC 13 -Wanalyzer-allocation-size.
---
 lib-src/ebrowse.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib-src/ebrowse.c b/lib-src/ebrowse.c
index 371fa6c938b..4b71f7447e0 100644
--- a/lib-src/ebrowse.c
+++ b/lib-src/ebrowse.c
@@ -3767,8 +3767,9 @@ main (int argc, char **argv)
          if (n_input_files == input_filenames_size)
            {
              input_filenames_size = max (10, 2 * input_filenames_size);
-             input_filenames = (char **) xrealloc ((void *)input_filenames,
-                                                   input_filenames_size);
+             input_filenames = xrealloc (input_filenames,
+                                         (input_filenames_size
+                                          * sizeof *input_filenames));
            }
           input_filenames[n_input_files++] = xstrdup (optarg);
           break;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]