emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-29 8574ef314c4: Fix loaddef generation with "; ; ; foo-autoload" c


From: Jim Porter
Subject: emacs-29 8574ef314c4: Fix loaddef generation with "; ; ; foo-autoload" cookies in external packages
Date: Fri, 4 Aug 2023 14:16:29 -0400 (EDT)

branch: emacs-29
commit 8574ef314c4250f7c10245cb8abe11dcc07bfe6d
Author: Jim Porter <jporterbugs@gmail.com>
Commit: Jim Porter <jporterbugs@gmail.com>

    Fix loaddef generation with ";;;foo-autoload" cookies in external packages
    
    This caused an issue where package-specific autoload cookies weren't
    being correctly recognized, so they got dumped into the package's main
    "<pkg>-autoloads.el" file, instead of "<pkg>-loaddefs.el" as they
    should (bug#65023).
    
    * lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--parse-file):
    Save match data when checking syntax.
---
 lisp/emacs-lisp/loaddefs-gen.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
index 5db9af21508..d7b9b131bc8 100644
--- a/lisp/emacs-lisp/loaddefs-gen.el
+++ b/lisp/emacs-lisp/loaddefs-gen.el
@@ -431,7 +431,8 @@ don't include."
                     ;; have an autoload cookie on the first column of a
                     ;; doc string or the like.  (The Emacs tree
                     ;; shouldn't contain any such instances.)
-                    (not (ppss-string-terminator (syntax-ppss))))
+                    (not (ppss-string-terminator
+                          (save-match-data (syntax-ppss)))))
             ;; ... and if we have one of these names, then alter outfile.
             (let* ((aname (match-string 2))
                    (to-file (if aname



reply via email to

[Prev in Thread] Current Thread [Next in Thread]