emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master e8d2bc75314: ; * lisp/emacs-lisp/comp-cstr.el (comp--normalize-ty


From: Andrea Corallo
Subject: master e8d2bc75314: ; * lisp/emacs-lisp/comp-cstr.el (comp--normalize-typeset0): Fix comment.
Date: Wed, 20 Mar 2024 07:02:28 -0400 (EDT)

branch: master
commit e8d2bc75314262d512d367c270c6d43201ef533f
Author: Andrea Corallo <acorallo@gnu.org>
Commit: Andrea Corallo <acorallo@gnu.org>

    ; * lisp/emacs-lisp/comp-cstr.el (comp--normalize-typeset0): Fix comment.
---
 lisp/emacs-lisp/comp-cstr.el | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/lisp/emacs-lisp/comp-cstr.el b/lisp/emacs-lisp/comp-cstr.el
index 70456a70de1..cbfb9540f03 100644
--- a/lisp/emacs-lisp/comp-cstr.el
+++ b/lisp/emacs-lisp/comp-cstr.el
@@ -288,13 +288,10 @@ Return them as multiple value."
                             (apply #'append
                                    (mapcar #'comp--direct-supertypes typeset)))
                 for subs = (comp--direct-subtypes sup)
-                when (and (length> subs 1) ;;FIXME: Why?
-                          ;; Every subtype of `sup` is a subtype of
-                          ;; some element of `typeset`?
-                          ;; It's tempting to just check (member x typeset),
-                          ;; but think of the typeset (marker number),
-                          ;; where `sup' is `integer-or-marker' and `sub'
-                          ;; is `integer'.
+                when (and (length> subs 1) ;; If there's only one sub do
+                                           ;; nothing as we want to
+                                           ;; return the most specific
+                                           ;; type.
                           (cl-every (lambda (sub)
                                       (cl-some (lambda (type)
                                                  (comp-subtype-p sub type))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]