[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Acl-devel] [PATCH] libacl: add acl_extended_file_nofollow()
|
From: |
Andreas Gruenbacher |
|
Subject: |
Re: [Acl-devel] [PATCH] libacl: add acl_extended_file_nofollow() |
|
Date: |
Mon, 4 Apr 2011 17:21:20 +0200 |
|
User-agent: |
KMail/1.12.4 (Linux/2.6.36-rc7+; KDE/4.3.5; i686; ; ) |
Kamil,
nice work. Some comments:
* We need to bump the version of libacl so that packages that contain programs
which use acl_extended_file_nofollow() can require the appropriate version of
libacl. Otherwise such packages would install, but the programs would fail to
load.
* I would rather not add a prototype for getxattr/lgetxattr.
* There are some minor comment and whitespace glitches.
Are you fine with the attached changes/fixes?
Thanks,
Andreas
fixes.diff
Description: Text Data