Re: [Acl-devel] [PATCH attr 0/5] modernize the build system

[Andreas Grünbacher]

Mike,

2014/1/8 Mike Frysinger <address@hidden>:
> The current attr build system is full of pain, but for upstream
> maintainers and for distro maintainers.  Punt all the hand written
> logic in favor of autotools.

The hand written logic stems from the old SGI build system, this stuff
hasn't been hand written for attr / acl. I'm more than happy to let it go.
Thanks a lot for working on this!

The patches look good, what I noticed was:

* "make install" puts xattr.conf into /usr/etc/ for me, this is not
where the file is expected.

* The library looks for xattr.conf in path ATTR_CONF which is
hard-coded to "/etc/xattr.conf".
  This needs to follow the autoconf settings.

* Where did ENABLE_MAN2 come from? It's not documented, and actually,
the man2 man pages
  do come from the libattr-devel package on the rpm based system I'm
on right now (a Fedora 19
  install). The man2 man pages should probably be on by default if
this hack is needed at all.

* The old build system has installed the man pages as .gz files, now
that doesn't happen anymore.
  I'm not sure if that matters.

Other than that, I don't see a reason why we shouldn't merge these changes fast.

Thanks,
Andreas