Re: [Acl-devel] [PATCH attr 0/5] modernize the build system

[Andreas Grünbacher]

2014/1/9 Mike Frysinger <address@hidden>:
> On Thursday 09 January 2014 13:18:50 Andreas Grünbacher wrote:
>> * "make install" puts xattr.conf into /usr/etc/ for me, this is not
>> where the file is expected.
>
> this is correct.  the default configure path is to use /usr/etc for its
> sysconfdir.  you need to explicitly do --sysconfdir=/etc.
>
> we could make the configure.ac script a bit more intelligent and have it
> default to /etc, but i think we should just leave it as is since this is the
> normal behavior w/autotool packages.  consider when you do 
> --prefix=/usr/local.
> it should be using /usr/local/etc and not /etc.

Yes, seems to work.

>> * The library looks for xattr.conf in path ATTR_CONF which is
>> hard-coded to "/etc/xattr.conf".
>>   This needs to follow the autoconf settings.
>
> agreed.  can i post that as a follow up patch rather than squashing into this
> series ?

Sure.

>> * Where did ENABLE_MAN2 come from? It's not documented, and actually,
>> the man2 man pages
>>   do come from the libattr-devel package on the rpm based system I'm
>> on right now (a Fedora 19
>>   install). The man2 man pages should probably be on by default if
>> this hack is needed at all.
>
> yes, i should have split that out into a sep patch.  i forgot about it during
> the overall development ;).

Yes, that would have been easier to review.

> the Linux man-pages project has been providing man pages for these syscalls
> for a while now.  Fedora explicitly deletes them from man-pages:
>         # part of libattr-devel
>         rm man2/{,f,l}{get,list,remove,set}xattr.2
>
> imo that's wrong.  the man-pages project is responsible for documenting the
> syscall interface which means it should be installing these pages.

Okay.

>> * The old build system has installed the man pages as .gz files, now
>> that doesn't happen anymore.
>>   I'm not sure if that matters.
>
> it did have support for that.  it's pretty unusual (but not uncommon) for
> packages to auto-compress things.  i don't see the point in handling this when
> distros already have logic to do it automatically.

If it's not strictly necessary, we can leave it out.

Thanks,
Andreas