Re: [Acl-devel] [PATCH 2/2] build: ship a pkgconfig file for libattr

[Mike Frysinger]

On Friday 10 January 2014 12:46:03 Jan Engelhardt wrote:
> On Friday 2014-01-10 18:40, Mike Frysinger wrote:
> >On Friday 10 January 2014 09:47:23 Jan Engelhardt wrote:
> >> --- a/Makefile.am
> >> +++ b/Makefile.am
> >> 
> >>    -DLOCALEDIR=\"$(localedir)\" \
> >>    -DSYSCONFDIR=\"$(sysconfdir)\"
> >> 
> >> +pkgconfdir = ${libdir}/pkgconfig
> >
> >this should be $(libdir) and not ${libdir}
> 
> It does not really matter - using {} to reference variables is
> accepted by make implementations, and probably even inspired by sh and
> the P family of scripting languages which have been using it for ages.

i'm aware.  however, the code base uses $(...) everywhere and it should not 
deviate for no good reason (of which i see none here).
-mike

signature.asc
Description: This is a digitally signed message part.