Re: [Acl-devel] [attr PATCH 1/3] Add explicit symbol versioning for attr_copy_action

[Dmitry V. Levin]

On Sat, Sep 19, 2015 at 03:19:32AM -0400, Mike Frysinger wrote:
> On 15 Sep 2015 19:41, Dmitry V. Levin wrote:
> > As all symbols that are part of public interface are expected
> > to be properly versioned, add versioning to attr_copy_action.
> > ---
> >  exports | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/exports b/exports
> > index 6b6ca17..253dbbf 100644
> > --- a/exports
> > +++ b/exports
> > @@ -55,3 +55,8 @@ ATTR_1.2 {
> >     attr_list;
> >     attr_listf;
> >  } ATTR_1.1;
> > +
> > +ATTR_1.3 {
> > +    global:
> > +   attr_copy_action;
> > +} ATTR_1.2;
> 
> this one i'm not sure about because i don't know what the symbol
> versioning policies are for libattr.

I'm not sure either, just using common sense.

> using ATTR_1.3 looks fine, but so would adding it to ATTR_1.2.
> Andreas will have to comment.

It has to be a new version, otherwise applications linked with versioned
attr_copy_action will not require libattr that provides that version,
which in turn will cause compatibility issues in some package management
systems.


-- 
ldv

pgpjcRfY1Pd2d.pgp
Description: PGP signature