Re: [Acl-devel] [RFC] Add attribute visibility("default") to API functions

[Mike Frysinger]

On 12 Feb 2016 16:39, Yury Usishchev wrote:
> > (2) just do in acl.h:
> > #ifndef ACL_API_EXPORT
> > # define ACL_API_EXPORT extern
> > #endif
> > (3) update config.h to define ACL_API_EXPORT to default visiblity
> > (4) update configure.ac to test for the flag directly -- we already have
> > the m4/visibility_hidden.m4 file in the codebase for this
> >
> > since all our source files should be including config.h first, we
> > then know the macro will be defined before pulling in acl.h.
>
> It will be better if we put it in include/misc.h like the hidden macros
> And I dont think we need to add another check for visibility("default")
> as it should be covered by visibility("hidden") check.
> 
> > there's no need to enumerate the definitions themselves.  just the
> > prototype is sufficient.
>
> As Andreas pointed out, information about visibility cannot be used outside
> acl build, so we should not place it in public headers. Thats why I annotated
> definitions.

my version didn't include visibility.  the public header *only* has the
three lines i posted earlier:
#ifndef ACL_API_EXPORT
# define ACL_API_EXPORT extern
#endif

that's the point of putting the define into config.h.
-mike

signature.asc
Description: Digital signature