Re: [Acl-devel] [RFC] Add attribute visibility("default") to API functions

[Yury Usishchev]

Hello Mike!

Mike Frysinger <address@hidden> writes:
> On 15 Feb 2016 19:40, Yury Usishchev wrote:
>> 0001-Rework-config.h-usage.patch - move #include "config.h" from misc.h to 
>> every source file.
>>   Note that I had to change 'libacl/perm_copy.h' as it is included first in 
>> many sources by build command.
>>   Also I patched sources in 'test' directory, and I am not sure if it should 
>> be done:)
>
> the tests look harmless, but should be fine.  pushed now.

Thanks!

>
>> 0002-Add-acl-libacl.h-include-where-needed.patch
>>   To address problem with undefined reference I added explicit #include 
>> <acl/libacl.h> to each source file with
>>   definitions of functions declared in 'include/libacl.h'.
>
> to make things nicer, i'm thinking it'd be best if libacl/libacl.h had
> the acl/libacl.h include.  all the files in libacl/ have to include that
> already.

Done.

>
>> 0003-Add-sys-acl.h-include-where-needed.patch
>>   Same for 'sys/acl.h'.
>>   This patch is not required, in all cases it was included implicitly by 
>> #include "libacl.h" or #include <acl/libacl.h>
>>   Also this patch may look better if merged with previous one.
>
> same here ... i think having the include in libacl/libacl.h is OK.

Done.

I also cleaned up a bit usage of headers and added #include "libacl.h" to 
libacl/acl_valid.c, it was missing :)

Pathces attached.

BR,
Yury Usishchev

0001-Cleanup-internal-headers-usage.patch
Description: 0001-Cleanup-internal-headers-usage.patch

0002-Add-visibility-default-attribute-for-api-functions.patch
Description: 0002-Add-visibility-default-attribute-for-api-functions.patch