[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Acl-devel] [ATTR] [PATCH] Cleanup visibility of API functions

From: Andreas Grünbacher
Subject: Re: [Acl-devel] [ATTR] [PATCH] Cleanup visibility of API functions
Date: Wed, 2 Mar 2016 17:30:34 +0100


2016-03-02 15:14 GMT+01:00 Yury Usishchev <address@hidden>:
> Hello!
> As discussed in 
> thread 
> I've prepared patch set for
> cleaning up visibility of API functions in attr.
> 0001-Cleanup-config.h-usage.patch:
>   adds config.h include before all other includes in all source files.
> 0002-Cleanup-visibility-of-API-functions.patch:
>   add m4 script from acl tree that checks for visibility attribute.
>   add call to new m4 macro from
>   add visibility attribute to API functions same way it was added in acl.
> Note: functions from syscalls.c are exported through linker script 
> and visibility needs to be set explicitly
> Note2: pragma usage in syscalls.c seems cleaner
> Note3: internal headers usage cleanup in attr was not needed
> Could you review attached patches please?

This looks okay; I've applied it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]