Re: [PATCH] tools: link libintl if discovered by AM_GNU_GETTEXT

[Arsen Arsenović]

Hi,

Andreas Grünbacher <agruen@gnu.org> writes:
> But with those mlibc warnings, are the resulting tools actually
> useful? This needs to be looked at before applying this change.
>
> Do the warnings correspond to the setlocale() calls in tools/getfacl.c?
The warnings are a fault of the implementation (mlibc doesn't implement
locales), however (after applying a few outstanding patches to mlibc),
the program does run and localize:

  bash-5.1# LANG=de getfacl /
  mlibc: uselocale() is a no-op
  mlibc: uselocale() is a no-op
  mlibc: __fsetlocking() is a no-op
  getfacl: Entferne führende '/' von absoluten Pfadnamen
  # file: .
  # owner: 1001
  # group: 1001
  user::rwx
  group::r-x
  other::r-x
  getfacl: .: No such process (ESRCH)
  bash-5.1# 

IIRC the Solaris libc also requires external gettext, so it might be
worth it to test on such a machine if you have access to one.  I
currently don't, though, so I couldn't test there.

The ESRCH error is a walk_tree failure, I never debugged where exactly
it comes from since I'm quite low on time today, but AFAICT it's
unrelated to the patch.  Reverting it and building with --disable-nls
yields:

  bash-5.1# getfacl /
  getfacl: Removing leading '/' from absolute path names
  # file: .
  # owner: 1001
  # group: 1001
  user::rwx
  group::r-x
  other::r-x
  getfacl: .: No such process (ESRCH)
  bash-5.1# 

Thanks,
-- 
Arsen Arsenović

signature.asc
Description: PGP signature