Re: [PATCH attr] build: Fix cross-compilation on musl-based systems

[Sam James]

> On 3 Dec 2022, at 12:18, Guillem Jover <guillem@hadrons.org> wrote:
> 
> The gettext implementation in musl does not define some of the internal
> symbols that AM_GNU_GETTEXT used to check for. This got fixed in gettext
> 0.19.8, but the AM_GNU_GETTEXT_VERSION macro requires a specific version
> even if the system contains a higher one. We switch to use the new
> AM_GNU_GETTEXT_REQUIRE_VERSION macro which requires at least a specific
> version, and bump the AM_GNU_GETTEXT_VERSION to the first one that had
> support for the new macro.
> 
> Signed-off-by: Guillem Jover <guillem@hadrons.org>
> ---
> configure.ac | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 27c2ef5..ee181e7 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -37,7 +37,10 @@ AC_SYS_LARGEFILE
> AM_PROG_AR
> LT_INIT
> 
> -AM_GNU_GETTEXT_VERSION([0.18.2])
> +# Minimal version supporting AM_GNU_GETTEXT_REQUIRE_VERSION.
> +AM_GNU_GETTEXT_VERSION([0.19.6])
> +# Require at least the following version, but use the latest available one.
> +AM_GNU_GETTEXT_REQUIRE_VERSION([0.19.8])
> AM_GNU_GETTEXT([external])
> 
> AC_ARG_ENABLE([debug],
> --

Lgtm and thanks!

signature.asc
Description: Message signed with OpenPGP