adonthell-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Adonthell-devel] Finding python wrappers from code


From: Kai Sterker
Subject: Re: [Adonthell-devel] Finding python wrappers from code
Date: Thu, 4 Aug 2011 21:00:46 +0200

2011/8/4 Michał Kaliński <address@hidden>:

> 2011/8/2 Kai Sterker <address@hidden>:
>> Btw,, if you let me know your github account name, I can add you as
>> contributor, so you can directly push your stuff to the central
>> repository in the future.
>
> Well, I'm new to git and github, but here's the name: mkalinski

Added you to adonthell.

Most of the time, you'll get by with git add, commit, push and pull.
If it gets more complicated, there are people around here that know it
pretty well. I haven't done much more than those few commands, save
for some simple branching and merging.

> BTW, I was working on that "character stuck in ceiling" thing you
> mentioned and noticed that there was no return value in
> character::put_state(). There were 4 trailing spaces at the last
> instruction in the method, so I presume return got deleted
> accidentally. I added return true at the end, seeing as other
> put_state methods usually do that. Is that how it should be?

Since character::put_state is declared to return a boolean, this
clearly the return should be there.

In general, put_state methods don't really have a chance for failure,
so they are a bit inconsistent in whether they return something or
not. For symmetry with get_state, a lot of them do anyway.

Kai



reply via email to

[Prev in Thread] Current Thread [Next in Thread]