[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[AUCTeX-devel] Re: [AUCTeX-diffs] Changes to auctex/ChangeLog

From: David Kastrup
Subject: [AUCTeX-devel] Re: [AUCTeX-diffs] Changes to auctex/ChangeLog
Date: Wed, 25 Jan 2006 00:05:56 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

Masayuki Ataka <address@hidden> writes:

> From: David Kastrup <address@hidden>
> Subject: Re: [AUCTeX-diffs] Changes to auctex/ChangeLog
> Date: Mon, 23 Jan 2006 22:16:25 +0100
>> Uh, no.  It _special-cases_ those two operating systems, but I don't
>> see anything that would prevent this function from running, for
>> example, with dviout for Windows.  _Exactly_ because the cases for
>> MS-DOS and PC-9801 are specially checked and treated.
> Okay.  I didn't think about backward compatibility.
> I've reverted my change.
> One comment from Ikumi-San.
>   dviout for Windows works with TeX-run-discard.
> And he suggests renaming TeX-run-dviout to TeX-run-discard-foreground,
> TeX-run-dviout should be alias to TeX-run-discard-foreground.
> I put the patch from Ikumi-San at the end of email.
> I feel good at Ikumi-San's change.

With the defalias catering for previous customizations, I guess the
change is ok.


> --- tex.el-11.82      Fri Dec  9 04:37:16 2005
> +++ tex.el    Wed Jan 25 00:44:37 2006
> @@ -235,8 +235,8 @@
>  TeX-run-silent: Start the process in the background.
> -TeX-run-dviout: Special hook for the Japanese dviout previewer for
> -PC-9801.
> +TeX-run-discard-foreground: Start the process in the foreground,
> +discarding its output.
>  To create your own hook, define a function taking three arguments: The
>  name of the command, the command string, and the name of the file to
> @@ -269,6 +269,7 @@
>                               (function-item TeX-run-discard)
>                               (function-item TeX-run-background)
>                               (function-item TeX-run-silent)
> +                             (function-item TeX-run-discard-foreground)
>                               (function-item TeX-run-dviout)
>                               (function-item TeX-run-ispell-on-document)
>                               (function :tag "Other"))

I'd propose to remove the "function-item TeX-run-dviout" here.
Previous customizations would still be matched by the "Other" tag and
thus could still be identified by and changed with customize, while we
wouldn't offer two predefined different names for the same
functionality through the customize interface.

Apart from that, the change seems ok to me.

David Kastrup, Kriemhildstr. 15, 44793 Bochum

reply via email to

[Prev in Thread] Current Thread [Next in Thread]