Re: [AUCTeX-devel] Fix for tex-jp.el

[Arash Esbati]

Ikumi Keita <address@hidden> writes:

> I would like to install the attached changes to tex-jp.el.  May I proceed?

Hi Ikumi,

I trust your patches all work well, I only have a minor comment:

>                  (t
> -                 (if (japanese-TeX-coding-ejsu locale-coding-system)
> -                     locale-coding-system 'euc-jp))))))
> +                 (let ((lcs
> +                        (cond
> +                         ((boundp 'locale-coding-system)
> +                          locale-coding-system)
> +                         ;; for xemacs
> +                         ((fboundp 'get-coding-system-from-locale)
> +                          (get-coding-system-from-locale
> +                           (current-locale))))))
> +                   (if (and lcs (japanese-TeX-coding-ejsu lcs))
> +                       lcs 'euc-jp)))))))

I vaguely remember that tests against (X)Emacs should be done via
`featurep' and not against a function or variable; hence I would write
something like this:

    (let ((lcs (if (featurep 'xemacs)
                   (get-coding-system-from-locale (current-locale))
                 locale-coding-system))))

Thanks, Arash