[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [AUCTeX-devel] Modifying error handling

From: Mosè Giordano
Subject: Re: [AUCTeX-devel] Modifying error handling
Date: Thu, 20 Apr 2017 00:01:10 +0200

Hi Keita,

2017-04-19 20:42 GMT+02:00 Ikumi Keita <address@hidden>:
> Hi all,
> I'm going to check in the following change.  Since loading tex-jp.el
> replaces `TeX-error-description-list' with Japanese help messages,
> comparison with a fixed string "No help available" no longer works after
> that.  Rather we should test whether `TeX-error-pointer' comes to the
> last element of `TeX-error-description-list'.
> diff --git a/tex-buf.el b/tex-buf.el
> --- a/tex-buf.el
> +++ b/tex-buf.el
> @@ -3306,7 +3306,8 @@
>         (let ((help (cdr (nth TeX-error-pointer
>                              TeX-error-description-list))))
>          (save-excursion
> -          (if (and (string= help "No help available")
> +          (if (and (= (1+ TeX-error-pointer)
> +                      (length TeX-error-description-list))
>                     (let* ((log-buffer (find-buffer-visiting log-file)))
>                       (if log-buffer
>                           (progn
> Though I have done a brief test with this change, feel free to revert
> the commit if you find any problems with this.

The fix looks sensible.  A request: please add tests when possible.
This ensures we won't break anything in the feature, this is
particularly important in areas that usually receive less love from
other developers (like support for Japanese), and so are more likely
to be unintentionally broken.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]