Re: [PATCH] fix delete-property handling

[Ikumi Keita]

Hi Artem,

>>>>> Artem Yurchenko <artemyurchenko@zoho.com> writes:
> I haven't seen any objections, so I moved on with restoring the old
> behaviour.

Thank you for your cooperation.

>>> +(define-obsolete-variable-alias 'TeX-refuse-unmatched-dollar
>>> + 'TeX-refuse-nested-math "13.4"

>> The next AUCTeX version would be 14. (The ELPA releases already reached
>> 14.) So the version should be "14" or "14.1".

> Since I've restored the old behaviour, it makes sense to preserve the
> old variable name.

OK.

>> In general, an elisp function whose name ends with "-mode" is a major or
>> minor mode function, or is expected to do something related to major or
>> minor modes, at least within AUCTeX source. Thus I'd like you to change
>> this name `TeX-insert-dollar-mode' to `TeX-insert-dollar-action' or
>> something like that for coherency. (Since it can be considered as a
>> private helper function, you might as well assign it a name
>> "TeX--insert-..."; but that isn't much important.)

> Done. However, I don't want to make it private, since the helper could
> be useful to other electric modes, which can enable or disable
> features based on the operation mode.

OK.

>> In addition, I'd request to provide appropriate patches for
>> doc/auctex.texi and doc/changes.texi, too. :-)

> Done.

Thanks. I'll add one minor modification, in addition to some trivial
adjustments:
----------------------------------------------------------------------
(defun TeX-insert-dollar-electric ()
  "Perform electric math symbol insertion.
See `TeX-electric-math'."
  (if (and (TeX-active-mark) (/= (point) (mark)))
      (TeX-insert-dollar-electric-region)
    (insert (car TeX-electric-math))
    (save-excursion (insert (cdr TeX-electric-math))))
  (TeX-math-input-method-off))       <-- CHANGED
----------------------------------------------------------------------
I moved the call to `TeX-math-input-method-off' out of the `if' form in
my local repository so that it's called always when
`TeX-insert-dollar-electric' runs, because this is the current behavior
of `TeX-insert-dollar'.

Now I think AUCTeX can incorporate your patches. Did your copyright
assignment process finish? If not, I'll push the change to the git repo
after you notify us the completion of the process.

Best regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW