autoconf-archive-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Comments, fixes and new items


From: Francesco Salvestrini
Subject: Comments, fixes and new items
Date: Tue, 4 Aug 2009 19:25:46 +0200
User-agent: KMail/1.9.10

Hi all,


Some comments:

* Licenses: I see files with shortened license forms (Licensed under the terms 
of the GNU General Public License). We should change them to the longer ones 
probably. We should add licenses where missing too.

* dist-xz: Is it really necessary ? I still find systems without xz support 
yet ...


Patches (I will push those agreed):

* 0001: COPYING is not in .gitignore, Is it deliberately on the way ?

* 0003: Some bugs introduced while cutting down my external code to suit our 
needs have been removed. The 'required' variable is now split 
into 'should_have' and 'must_have' in order to give more flexibility to 
tests. The Makefile is still in the most-portable form, it will be tweaked 
and rearranged later. I've added some tests (initial work). They should run 
stright out of the box even if some of them require further work. Let's see 
if that mess suits our needs. *This patch applies over the previous one*.

* 0002: For ax_with_prog.m4:
  
  * Excessive quoting introduced in the latest changeset: Fixed
  * Portability problem introduced in the latest changeset: Fixed

NOTE: The `-a', `-o', `(', and `)' operands for 'test' are not portable and 
should be avoided. 

grep -l -e "test\ .*\ \-a" *.m4

ac_prompt_user_no_define.m4
ac_python_devel.m4
acltx_converting_fig.m4
acltx_converting_jpg_eps.m4
acltx_converting_png_eps.m4
ax_boost_base.m4
ax_check_gl.m4
ax_check_glut.m4
ax_count_cpus.m4
ax_gcc_archflag.m4
ax_lib_beecrypt.m4
ax_lib_crypto.m4
ax_lib_expat.m4
ax_lib_mysql.m4
ax_lib_nettle.m4
ax_lib_oracle_oci.m4
ax_lib_postgresql.m4
ax_lib_xalan.m4
ax_lib_xerces.m4
ax_lib_xml_security.m4
check_zlib.m4
immdx_lib_metis.m4
lua.m4
mp_with_curses.m4

ac_prompt_user_no_define.m4 is marked obsolete thus it doesn't worth the 
change. Applying the same concept to all the others ... it should be better 
to look && mark for obsolescence first and mass-fix later on maybe (I'll 
provide the fixes later).

Francesco

-- 
Deliberation, n.:
        The act of examining one's bread to determine which side it is
        buttered on.
                -- Ambrose Bierce, "The Devil's Dictionary"

Attachment: 0003-Initial-test-framework.patch
Description: Text Data

Attachment: 0002-Excessive-quoting-and-portability-problems-fixed.patch
Description: Text Data

Attachment: 0001-Added-COPYING-to-.gitignore.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]