Re: make check bug report

[Akim Demaille]

[Arg, sorry, meant to send it to patches.]

>>>>> "Nicolas" == Nicolas Joly <address@hidden> writes:

Nicolas> On Thu, Apr 19, 2001 at 06:56:03PM +0200, Akim Demaille
Nicolas> wrote:
>> >>>>> "Tim" == Tim Van Holder <address@hidden> writes:
>> 
Tim> Looks like most of these result from an outdated Perl.
>> Hm, I forgot about this...  We should find a means to have
>> autoupdate exit 77 if not 5.005.

Nicolas> This behaviour applies to systems that do not have Perl
Nicolas> installed too.

Tim> Akim, can autoupdate run on 5.004, or does it require 5.005?
>> I don't know, and I don't want to try!  I seem to recall there were
>> reports that made it mandatory to require 5.005.  Nicolas Joly
>> might remember.

Nicolas> Sure, with `use 5.005;' directive.

Tim> If the latter, we should definitely consider having autoconf's
Tim> configure reject older Perls.

>> Yes and no.  Yes, that would be cleaner, but it is not fundamental
>> (and actually I consider a misfeature that we don't install
>> autoscan and autoupdate when the user does not have Perl).  As is,
>> autoupdate exits properly.  It is the test suite which is broken.

Nicolas> I agree, and made the attached patch to solve this problem.

Thanks Nicolas, I'm applying your patch.

        Akim


Index: ChangeLog
===================================================================
RCS file: /cvs/autoconf/ChangeLog,v
retrieving revision 1.1364
diff -u -r1.1364 ChangeLog
--- ChangeLog   2001/04/18 16:50:13     1.1364
+++ ChangeLog   2001/04/20 11:27:07
@@ -1,3 +1,9 @@
+2001-04-20  Nicolas Joly  <address@hidden>
+
+       * tests/atspecific.m4 (AT_CHECK_AUTOUPDATE): Be robust to missing
+       or broken autoupdate.
+       * tests/tools.at: Likewise.
+
 2001-04-18  Tim Van Holder  <address@hidden>
 
        * acgeneral.m4 (_AC_INIT_SRCDIR): Handle
Index: tests/atspecific.m4
===================================================================
RCS file: /cvs/autoconf/tests/atspecific.m4,v
retrieving revision 1.41
diff -u -r1.41 atspecific.m4
--- tests/atspecific.m4 2001/02/15 23:36:49     1.41
+++ tests/atspecific.m4 2001/04/20 11:27:07
@@ -104,7 +104,8 @@
 # AT_CHECK_AUTOUPDATE
 # -------------------
 m4_define([AT_CHECK_AUTOUPDATE],
-[AT_CHECK([autoupdate --autoconf-dir $at_top_srcdir], 0,
+[AT_CHECK([autoupdate --version || exit 77], ignore, ignore, ignore)
+ AT_CHECK([autoupdate --autoconf-dir $at_top_srcdir], 0,
           [], [autoupdate: `configure.ac' is updated
 ])])
 
Index: tests/tools.at
===================================================================
RCS file: /cvs/autoconf/tests/tools.at,v
retrieving revision 1.29
diff -u -r1.29 tools.at
--- tests/tools.at      2001/03/19 14:54:39     1.29
+++ tests/tools.at      2001/04/20 11:27:07
@@ -431,6 +431,7 @@
 ]])
 
 # Checking `autoupdate'.
+AT_CHECK([autoupdate --version || exit 77], ignore, ignore, ignore)
 AT_CHECK([autoupdate --autoconf-dir $top_srcdir], 0, [],
          [autoupdate: `configure.ac' is updated
 ])
@@ -460,6 +461,7 @@
 )
 
 # Checking `autoupdate'.
+AT_CHECK([autoupdate --version || exit 77], ignore, ignore, ignore)
 AT_CHECK([autoupdate --autoconf-dir $top_srcdir], 0, [],
          [autoupdate: `configure.ac' is updated
 ])
@@ -481,6 +483,7 @@
 AC_PREREQ($at_version)
 EOF
 
+AT_CHECK([autoupdate --version || exit 77], ignore, ignore, ignore)
 AT_CHECK([echo "AC_PREREQ(1.0)" |
             autoupdate --autoconf-dir $top_srcdir -],
          0, [expout], [])